Open
Conversation
Squashed from: tlaurion@2df1c8b tlaurion@447d464 then, updated EC revision as per: Dasharo/ec#82 (comment) Signed-off-by: Maciej Pijanowski <maciej.pijanowski@3mdeb.com>
Required to to build dasharo-ec module. Need to pin SDCC version to 4.2.0 to avoid Dasharo/dasharo-issues#1785 and be in sync with ec-sdk: Dasharo/ec-sdk#2 Using 3.8.0 in nix toolchain (as originally used in ec-sdk) was not feasible: linuxboot#2062 (comment) Signed-off-by: Maciej Pijanowski <maciej.pijanowski@3mdeb.com>
…mal changes to build Dasharo-EC Signed-off-by: Thierry Laurion <insurgo@riseup.net>
tlaurion
reviewed
Apr 9, 2026
site-local/config
Outdated
|
|
||
| ifeq "novacustom-v560tu" "$(BOARD)" | ||
|
|
||
| export CONFIG_COREBOOT_LOCALVERSION="\(coreboot+heads\) v0.9.1" |
tlaurion
reviewed
Apr 9, 2026
| CONFIG_SOFTWARE_CONNECTION_MANAGER=y | ||
| CONFIG_SOC_INTEL_COMMON_BLOCK_VTD=y | ||
| CONFIG_ENABLE_EARLY_DMA_PROTECTION=y | ||
| # CONFIG_ENABLE_EARLY_DMA_PROTECTION is not set |
Collaborator
There was a problem hiding this comment.
not fixed by bumping fsp?
tlaurion
reviewed
Apr 9, 2026
| CONFIG_GENERIC_LINEAR_FRAMEBUFFER=y | ||
| CONFIG_LINEAR_FRAMEBUFFER=y | ||
| CONFIG_BOOTSPLASH=y | ||
| # CONFIG_BOOTSPLASH is not set |
Collaborator
There was a problem hiding this comment.
please review config from other pr
tlaurion
reviewed
Apr 9, 2026
site-local/config
Outdated
| ifeq "novacustom-v560tu" "$(BOARD)" | ||
|
|
||
| export CONFIG_COREBOOT_LOCALVERSION="\(coreboot+heads\) v0.9.1" | ||
| export CONFIG_COREBOOT_SMBIOS_PRODUCT_NAME="V54x_6x_TU" |
Collaborator
There was a problem hiding this comment.
branding overrides (bootslash and site-local/config should be in dasharo fork not upstream
tlaurion
requested changes
Apr 9, 2026
Collaborator
tlaurion
left a comment
tlaurion
left a comment
There was a problem hiding this comment.
see review, most importantly bootsplash removal, site-local override and coreboot cojfigs in oldconfig which seem still uefi release oriented.
- Remove leading tabs from ifeq variable assignments (Make parse error) - Move post-build steps (cp, dd, touch) out of dasharo-ec_target into a proper Make rule; _target is now only make arguments - Set dasharo-ec_output to ec.rom (the actual artifact, not .built) - Add -$(BOARD) suffix to dasharo-ec_base_dir and dasharo-ec_dir so v540tu and v560tu maintain independent build trees and ec.rom files - Add explicit rule to copy and zero-pad ec.rom to 128 KB - Fix coreboot copy rule: use FORCE + cmp so the recipe always runs but only updates the destination (and its mtime) when content differs, preventing the mtime race between boards sharing coreboot_base_dir Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Collaborator
|
Can't boot qubesos 4.3 iso from this PR nor the other (worst : kernel oops there), here cannot get anaconda. Can you boot anything? Also both PR have different coreboot commit and different platform names in config
|
Collaborator
|
One cannot internally upgrade from heads on v540tu either since platforms strings don't match Notebook (rom) != Clevo (smibios)
|
tlaurion
added a commit
to tlaurion/heads
that referenced
this pull request
Apr 10, 2026
…with make BOARD=X coreboot.save_in_oldconfig_format_in_place helper Signed-off-by: Thierry Laurion <insurgo@riseup.net>
tlaurion
added a commit
to tlaurion/heads
that referenced
this pull request
Apr 10, 2026
…with make BOARD=X coreboot.save_in_oldconfig_format_in_place helper Signed-off-by: Thierry Laurion <insurgo@riseup.net>
Collaborator
|
@filipleple please review commit logs of https://github.com/linuxboot/heads/pull/2039/commits One of those regression testing done in january 4th was f82d7e8 If not, we have a problem, we agreed on Clevo string back in #1913. We cannot change it otherwise internal flashing won't be possible. |
Collaborator
|
Please diff coreboot configs vs pre_release_dasharo_101_rc3 and explain/adapt:
|
Contributor
Author
|
@tlaurion yes I managed to successfully flash, run, and boot Qubes OS (on v56) and DTS (both v56 and v54). Though, I've gone the Ignore everything and just boot route, haven't yet tested reownership and TOTP/HOTP. I didn't run into the flashing issue since I was flashing from our EDK2 release, where we'd switched from I'm not sure if there's any problem settling for the Since I have the core of the release done, that's building and booting both platforms from the new revision including a successful EC update on both, I'll now get to inspecting the minute config differences and looking for anything I'm missing from #2039. Thank you for being proactive and helping out. UPDATE:
|
filipleple
force-pushed
the
mtl_release
branch
2 times, most recently
from
2245a11 to
f9a56fa
Compare
Contributor
Author
|
@tlaurion I've minimized the diff of the configs. Currently, the boards build and boot. I've also applied the split into multiple EDIT: looks like the CI fails are caused by CI cache invalidation exposing pre-existing problems, not by actual bugs in this PR, so ignoring them |
Collaborator
pushed additional 3 commits to account for changes under #2039. nv4x_adl does't build local for me still |
Collaborator
|
Also trying to build, and accumulate workspace caches so rebuilds of heads do not take forever and abuse circleci free tier compute time, since number of coreboot forks exploded in recent years but now buildstacks are also tag specific mostly per board variant and cannot reuse coreboot upstream release tarballs.... Will see if new approach works under last commit under #2039 which attempts to combine buildstack per tag shared to build boards. per arch and then save_cache. Will see. |
Collaborator
Booting from right side usb thumb drive usb-a port results in:
Fine on left side one. |
Collaborator
Which requires setting time to it by guidance once after disconnecting cmos battery so totp is good? That way if system clock is < 2023 or some, Heads triggers for time correction. Was tested in original PR per external flashing. |
Collaborator
We agreed on string to use on original port.
Exactly, this would break UX, we can't expect users to type those manually. Internal upgrade should be as easy as selecting flashing option, user selecting zip file and be happy. Q: is a plugged required for ec upgrade or usbc ok? |
Contributor
Author
@tlaurion Right, for this condition to get triggered the
I'm pretty sure it has to be the barrel jack power connector plugged in.
I can't manage to reproduce this, v56 nor v54, DTS nor Fedora installer. With Qubes, please note that it's necessary to use the kernel-latest option for reliable meteorlake support
Pushed updated config, builds now, boots into DTS and Qubes |
Open
modules/coreboot
Outdated
| sed -i '/^CONFIG_MAINBOARD_SMBIOS_MANUFACTURER/d' $(build)/$(coreboot_dir)/.config; \ | ||
| echo 'CONFIG_MAINBOARD_SMBIOS_MANUFACTURER="$(CONFIG_COREBOOT_SMBIOS_MANUFACTURER)"' >> $(build)/$(coreboot_dir)/.config; \ | ||
| fi; \ | ||
| sed -i 's|@COREBOOT_BUILD_DIR@|$(build)/$(coreboot_dir)|g' "$(build)/$(coreboot_dir)/.config"; \ |
Contributor
There was a problem hiding this comment.
Is @COREBOOT_BUILD_DIR@ actually used somewhere?
Collaborator
There was a problem hiding this comment.
sorry about d69667d can't push in this branch but no, COREBOOT_BUILD_DIR is not desired.
Collaborator
|
@filipleple ns50 also needs fixes as nv4x_adl |
tlaurion
added a commit
that referenced
this pull request
Apr 14, 2026
- Re-enable CONFIG_DASHARO_FIRMWARE_UPDATE_MODE=y (was incorrectly disabled) - Enable CONFIG_DRIVERS_GENERIC_CBFS_SERIAL=y (required for Dasharo) - Re-enable CONFIG_USE_PC_CMOS_ALTCENTURY=y (reverted broken commit) - Disable bootsplash (CONFIG_BOOTSPLASH=n, CONFIG_BOOTSPLASH_IMAGE=n) - Remove unused @COREBOOT_BUILD_DIR@ sed replacement in modules/coreboot
…port - config/coreboot-novacustom-v560tu.config: switch EC from SYSTEM76_EC to DASHARO_EC (CONFIG_EC_DASHARO_EC=y, _UPDATE=y, _UPDATE_FILE="ec.rom"), matching the v540tu change already in this branch - modules/dasharo-ec: strip UNTESTED_/EOL_ board name prefixes before the board model mapping so that boards not yet promoted (e.g. UNTESTED_nitropad-ns50) resolve correctly without a separate entry - modules/dasharo-ec: add board model mappings for novacustom-nv4x_adl (ns5x_adl - nv4x_adl) and nitropad-ns50 (ns5x_adl) - modules/dasharo-ec: drop redundant sh -c wrapper from cp recipe; Make already invokes recipe lines via the shell - modules/dasharo-ec: replace dd seek-based padding with truncate --size=128KiB, as suggested in review (ec.rom is always smaller than 128 KiB) - modules/dasharo-ec: indent ifeq variable assignments with a tab for readability Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
…nges When the coreboot git commit changes (canary mismatch), remove and recreate the board-specific build directories to prevent stale artifacts from causing compilation failures. This eliminates the need for manual `rm -rf build/x86/BOARD` before rebuilding after coreboot canary updates in development cycles (when creating patches). One currently still has to, eg: echo "bogues repo url + commit hash" | sudo tee /home/user/heads/build/x86/coreboot-25.09/.canary Current logic then: 1. Detects canary changes and triggers repository cleanup 2. Removes both Heads board directory (build/x86/BOARD) and coreboot board directory (build/x86/coreboot-*/BOARD) that contain stale build artifacts 3. Recreates empty board directories for the subsequent build 4. Allows patches to apply cleanly without Ada compilation errors This ensures Ada builds work correctly after coreboot updates without manual intervention (resync repo, apply patches, clean artifact dirs and rebuilds only what changed). Signed-off-by: Thierry Laurion <insurgo@riseup.net>
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
…g (Improve performance by lowering the EPP value from the power-on default of 0xb3 (70%) to 0x73 (45%). Lower value = higher performance.) Test fix for Dasharo/dasharo-issues#1711 related: - linuxboot#2039 - Dasharo/dasharo-issues#1711 - linuxboot#1894 Signed-off-by: Thierry Laurion <insurgo@riseup.net>
…nreleased The coreboot module for NovaCustom MTL boards was renamed from 'dasharo' to 'dasharo_v56'. The Heads patch system resolves patch directories as <module_name>[-<patch_version>], so with module coreboot-dasharo_v56 and patch_version=unreleased the expected path is patches/coreboot-dasharo_v56-unreleased/. Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Signed-off-by: Filip Lewiński <filip.lewinski@3mdeb.com>
Contributor
Author
Collaborator
|
@filipleple @SergiiDmytruk please review #2039 (comment) and feel free to sqaush all of those here |
tlaurion
added a commit
that referenced
this pull request
Apr 15, 2026
Disabling CMOS_ALTCENTURY was decided in PR #2082 discussion. These two boards regressed from origin/master where it is disabled. Matches v540tu and ns50 which are already disabled. Note: SMBIOS strings (MAINBOARD_VENDOR, MAINBOARD_SMBIOS_MANUFACTURER, MAINBOARD_SMBIOS_PRODUCT_NAME) are intentionally preserved as-is per origin/master. These values are required by flashprog for ROM identification (current ROM vs ROM to flash) and must not change. Fixes: unaddressed comment by filipleple on PR #2039 Signed-off-by: Thierry Laurion <insurgo@riseup.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the build configuration for NovaCustom V540TU and V560TU boards, focusing on switching from Clevo to NovaCustom mainboard definitions, updating the build environment, and aligning with the Dasharo EC and firmware stack. The changes improve consistency, bring in newer firmware components, and update several settings for hardware compatibility and feature support.
CI Environment Update:
.circleci/config.ymljobs fromtlaurion/heads-dev-env:v0.2.7tov0.2.9to ensure builds use the latest development environment. [1] [2] [3] [4]Board and Mainboard Configuration:
config/coreboot-novacustom-v540tu.config, and enabled the appropriate NovaCustom board options. This aligns the configuration with the actual hardware and firmware stack. [1] [2] [3] [4]CONFIG_DASHARO_EC=yto bothboards/novacustom-v540tu/novacustom-v540tu.configandboards/novacustom-v560tu/novacustom-v560tu.configto enable Dasharo EC support. [1] [2]Firmware and Embedded Controller:
v1.0.1, adjusted FSP paths and types, and enabled several new firmware and memory settings for improved hardware compatibility and debugging. [1] [2] [3] [4] [5] [6] [7] [8] [9]Feature and Peripheral Configuration:
These changes collectively modernize the firmware configuration for NovaCustom V540TU/V560TU, improve maintainability, and ensure compatibility with Dasharo EC and the latest coreboot features.